microsoft / microsoft/TypeScript
Ability to type check factory constructed source files
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Go
- Sterne
- 111k
- Forks
- 14.3k
- Ø Merge
- 2 T. 4 Std.
- Gemergte PRs (30 T.)
- 132
Beschreibung
Suggestion
It would be nice to have the ability to type check factory constructed source files.
For example, say I create some ASTs like so, where params.module.body is some foreign AST that I'm converting to a tsc AST:
const sourceFile = ts.factory.createSourceFile(
params.module.body.map(item => convertModuleItem(item)),
ts.factory.createToken(ts.SyntaxKind.EndOfFileToken), // side note... i'm unsure why this param exists
ts.NodeFlags.None,
);
sourceFile.fileName = params.fileName;
sourceFile.text = params.fileText;
setRange(sourceFile, params.module); // my own function that sets the range
...it would be better to be able to use these source files without having to implement all the necessary hacks. For example, not having to do...
(sourceFile as any).parseDiagnostics = [];
(sourceFile as any).bindDiagnostics = [];
...along with figuring out how to set many more internal properties (ex. identifiers, pragmas, imports, etc... etc...).
🔍 Search Terms
type check transformed AST source file
✅ Viability Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
💻 Use Cases
- Ability to do AST transformations then feed that back through the type checker without having to print out the AST to a string then reparsing that string to an AST using the TS compiler.
- Ability to take a non-tsc AST representation of an AST and construct it to a tsc AST using the factory methods. This would be useful in Deno as it is already parsing an AST with swc and so it could pass that AST over to the TS compiler for type checking.
Viability?
I understand this is a huge ask and the main reason I'm opening this is to ask how viable it is?
I believe the type checker would need to be changed to sparingly consult the source file text or node ranges and some of the code in the parser that sets internal properties would need to be extracted out to support it being lazily computed in addition to when it's parsed. Additionally, factory methods would have to clear the appropriate internal properties on nodes when they're transformed so that they will be lazily computed in the future when the type checker goes to retrieve them. Anything else?
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne damit, den Einstiegspunkt factory createSourceFile zusammen mit den im Issue beschriebenen Interna des Type Checkers und Parsers zu lesen. Als erledigt gilt die Aufgabe, wenn von der Factory erstellte Source Files an den Type Checker übergeben werden können, ohne parseDiagnostics, bindDiagnostics, identifiers, pragmas, imports und andere interne Eigenschaften manuell zu setzen.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- typescript
- Bereich
- compilers
- Issue-Typ
- Feature
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Aktivitätsstatus
- Veraltet
- Klarheit
- Muss geklärt werden
- Anfängerfreundlichkeit
- 20/100