microsoft / microsoft/TypeScript
Allow for safely accessing properties that arguments to a type guard function could potentially have
まだ誰も着手していません。
- 主要言語
- Go
- スター
- 111k
- フォーク
- 14.4k
- 平均マージ
- 1日 19時間
- マージ済み PR(30日)
- 117
説明
Suggestion
🔍 Search Terms
type guard allow unknown
✅ Viability Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
⭐ Suggestion
It would be helpful if arguments to a type guard function could be treated as having the potential to be anything, while at the same time making no new assumptions about its type.
📃 Motivating Example
Say we had this Foo class, and we wanted to write a custom type guard to detect if something is a Foo.
type Foo = {
bar: string;
}
function isFoo(value: any): value is Foo {
return typeof value.bar === 'string';
}
This has the downside of using any, which is often linted against and unsafe. We'd like to be able to use unknown instead, but then it would complain about accessing value.bar. If we go with the same pattern as the example in the documentation, we get something like this:
function isFoo(value: unknown): value is Foo {
return typeof (value as Foo).bar === 'string';
}
This also isn't great, because we're using as and thus losing whatever type safety we had about value. In both of these cases, we're ignoring that value could be undefined, and thus break this function.
This could be solved with using new syntax for "expanding" the argument, or by always allowing the argument to be expanded to its limit when its being tested by a type guard.
function isFoo(value: unknown): value is Foo {
return typeof value?.bar === 'string';
}
This complains in the Playground because of value?.bar, even though it's valid for any possible arguments. It could also be written as
function isFoo(value: unknown): value is Foo {
if (!value) {
return false;
}
return typeof value.bar === 'string';
}
since in the second path it would have decided that value isn't nullish, and thus value.bar is safe.
The idea is that the argument starts off as a blank slate (or with whatever its initial type is if it isn't unknown) and anything can be accessed on it, provided it's been proven to exist.
If this is considered to big of a change in behavior, it could be introduced as a keyword for the argument (and then possibly used outside of type assertions):
function isFoo(expandable value: unknown): value is Foo {
return typeof value?.bar === 'string';
}
💻 Use Cases
This would be useful for almost any type guard function that has to take in something unknown as an argument. Even for something with a baseline type, it would help prevent errors from liberal use of any and casting.
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
narrowing のドキュメントにある type-predicate の例から始め、リンク先の Playground のケースを再現します。unknown、any、cast、optional-chaining、null-check の各バリエーションを比較し、安全なプロパティアクセスに必要な型システムの挙動と構文を判断します。意図した type guard が安全でない cast なしで受け入れられ、null 安全性が維持されれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- javascript, typescript
- 領域
- compilers
- issue の種類
- 機能追加
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 28/100