microsoft / microsoft/TypeScript
Aggregate function assertions
まだ誰も着手していません。
- 主要言語
- Go
- スター
- 111k
- フォーク
- 14.3k
- 平均マージ
- 2日 4時間
- マージ済み PR(30日)
- 132
説明
Suggestion
🔍 Search Terms
Multi-assertions, function assertion signatures, type assertions, aggregate assertions
✅ Viability Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
⭐ Suggestion
Allow functions that assert a type or condition to assert multiple types or conditions
(Maybe?) Allow functions with "asserts" signatures to return a type other than void.
(Update: the secondary goal is covered by other issues)
💻 Use Cases
It allows multiple type assertions at once.
// declare AssertionError
function assert(x: unknown, y: unknown): (asserts x is number) & (asserts y is number) {
if (typeof x !== "number" || typeof y !== "number") {
throw new AssertionError("Assert failed: 'x' and 'y' are not both numbers");
}
}
or
function safeAdd(x: unknown, y: unknown): (number) & (asserts x is number) & (asserts y is number) {
if (typeof x !== "number" || typeof y !== "number") {
throw new AssertionError("`x` and `y` are not both numbers");
} else {
return x + y;
}
}
or
declare function safeAdd(...args: unknown[]): asserts args is [number, number];
No idea what the syntax would be, but this should give the idea.
📃 Motivating Example
My use for this was that I had a function that accepted two parameters. It only operated if the first parameter was of a type (T), it also had an overload for the second parameter being the same type (T) or anything else.
declare function assertIsT (x: unknown): asserts x is T;
declare function isT (x: unknown): x is T;
function f (x: unknown, y: unknown): asserts x is T;
function f (x: T, y: T | H) {
assertIsT(x);
// x: T
if ( isT(y) ) {
// ... y: T
} else {
// ... y: H
}
}
This was meant to be "JavaScript-compatible" code, as in, it could be used by a non-TS user with relative type safety, but, the assertion seems like extra work, as if I'm being over-cautious, so I wanted to simplify it:
declare function isT (x: unknown, y: unknown): (asserts x is T) & (y is T);
function f (x: unknown, y: unknown): asserts x is T;
function f (x: T, y: T | H) {
if ( isT(x, y) ) {
// ... x: T
// ... y: T
} else {
// ... x: T
// ... y: H
}
}
Now, it's terse and straightforward, while retaining type-safety.
(I am not advocating any specific syntax for the aggregation/mixing)
I tried to get this to work with function overloads, but it wasn't happening.
Playground link
Related issues?
https://github.com/microsoft/TypeScript/issues/40562
https://github.com/microsoft/TypeScript/issues/34636
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
assertion-signature の例とリンク先の Playground の再現を起点にし、その後、関連する issue 40562 と 34636 を読んでください。assertions の組み合わせ(提案されている tuple assertion を含む)に関する意図された構文と型チェックの動作を明らかにしてください。言語設計と互換性への影響が解決されれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- typescript
- 領域
- compilers
- issue の種類
- 機能追加
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 活発さ
- 停滞
- 明瞭さ
- 説明が足りない
- 初心者へのやさしさ
- 25/100