microsoft / microsoft/TypeScript
Add compiler option to allow module types to be checked in non module output files
まだ誰も着手していません。
- 主要言語
- Go
- スター
- 111k
- フォーク
- 14.3k
- 平均マージ
- 1日 19時間
- マージ済み PR(30日)
- 117
説明
Search Terms: import type, export {}
Suggestion
In #41513 and #41562 projects are broken by a design change to always include export {}; in the JS output if import or import type is in the TS source, regardless of whether it is in the JS output. This is a breaking change for a lot of developers and painful to fix (and by fix I mean practically get the output of our TS project to run in browsers, not necessarily adhere to ECMA spec compliance and best possible practice).
However, export {}; considered desirable:
You're free to suggest a new compiler option but this is the intentional behavior.
Originally posted by @RyanCavanaugh in https://github.com/microsoft/TypeScript/issues/41513#issuecomment-727057724
Please could we have a new compiler option to not force all files that in any way use ES modules to always have to include export {}; in the JS output.
I'm not sure of the best way for this to be applied, but the goal would be
- Type checking compatible with an ESM project.
- Output compatible with the current state of module support in browsers.
This could be:
- A compiler option that causes
import typeto not implicitly convert output to a module, (my preference because it still avoids any output JS havingimportwithoutexport, which caused #38696) or - A compiler option to not add
export {};to all modules, or - A
//@directivewe add to a file to express our intent to not output a module, or - A new
reference type ...TS-only syntax to signal that we want to use the definition but not output a module
Whatever is easiest to code and causes least friction/confusion for the community.
Use Cases
I have a large TS project that uses numerous web workers, a service worker and web components that load side effects.
In the first two cases including export {}; breaks the resulting JS, as these workers are not modules and are not intended to produce module loaded JS output.
In the case of side effect web components no export is expected (they use customElements.define) so it's just wasted bytes, but it doesn't break anything. Across a project with a lot of components the many export {}; that will never be referenced by anything adds up.
In addition during migration between different reference types it may be extremely beneficial to not strictly enforce adherence to one type or the other, at least while not in production. Any modules = all must be modules effectively makes this migration harder, even if it is a sound best practice.
Examples
I have a model MyModel.d.ts.
In worker.ts I want TS to check my code against this model:
import type MyModel from './MyModel';
const test: MyModel = {};
test.propertyInModel = 1; // works and has intellisense
// test.propertyNotInModel = 1; throws compile error!
I want to use the JS output this with a worker in another file:
const worker = new Worker('path/worker.js');
This worked in 3.8, but fails in 4.0 due to #41562
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code (it would fix a lot of projects broken by 4.0)
- This wouldn't change the runtime behaviour of existing JavaScript code (it would be opt-in)
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) (we're removing additional content that wasn't in 3.8)
- This feature would agree with the rest of TypeScript's Design Goals. (particularly 4, 7 and 11)
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
実装ファイルやテストは指定されていません。まず関連する issue #41513 と #41562、およびここでの議論を読み、その後、import type と export {} がモジュールの分類と出力される JavaScript にどのような影響を与えるかを追ってください。完了の条件は、ESM 互換の型チェックを維持しながら、モジュールではない出力を可能にする、明確に定義された opt-in 動作があり、説明されている worker と web-component のケースをカバーしていることです。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- typescript
- 領域
- compilers
- issue の種類
- 機能追加
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 25/100