microsoft / microsoft/TypeScript
Set esModuleInterop to "true" by default
まだ誰も着手していません。
- 主要言語
- Go
- スター
- 111k
- フォーク
- 14.3k
- 平均マージ
- 2日 4時間
- マージ済み PR(30日)
- 132
説明
Search Terms
- esModuleInterop
Suggestion
Change esModuleInterop from being an opt-in to instead be an opt-out, taking one step further towards deprecating the non-esModuleInterop mode and make esModuleInterop the only supported mode going forward (which has to be the long term goal).
Use Cases
When Typescript 2.7 introduced esModuleInterop almost 3 years ago it emphasized clearly that:
We highly recommend applying it both to new and existing projects.
esModuleInterop is also a recommended option to set in tsconfig.json and when one runs tsc --init it gets set to true automatically.
However, the fact that it still is opt-in makes that non-esModuleInterop mode is still very prevalent, which kind of works against the very problems it was meant to fix – as rather than having just the pre-esModuleInterop functionality, modules now have to try to make things work across both options – and on top of that increasingly have to work with TS-validated JS.
All in all, that causes problems: https://github.com/fastify/env-schema/pull/17
And is hard to wrap ones head around: https://github.com/fox1t/modules-playground
Even if one really tries: https://github.com/fox1t/modules-playground/pull/3
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- It would for all code which haven't yet adopted
esModuleInterop, but it would make it easier to get TypeScript and JavaScript code to stay compatible with one another
- It would for all code which haven't yet adopted
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- It would emit different JS for all code which haven't yet adopted
esModuleInterop, but it would make it easier to get TypeScript and JavaScript code to stay compatible with one another
- It would emit different JS for all code which haven't yet adopted
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
- Apart from
Do not cause substantial breaking changes from TypeScript 1.0.
- Apart from
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
まず、esModuleInterop が tsconfig.json でどのように表現され、tsc --init によってどのように初期化されるかを追跡し、次に、そのデフォルト値を変更した場合のコンパイラーと出力される JavaScript への影響を評価します。既存のプロジェクトに対してオプトアウトの動作をどのように機能させるべきかを確立し、breaking change の影響を解決できれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- javascript, typescript
- 領域
- compilers
- issue の種類
- 機能追加
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 25/100