microsoft / microsoft/TypeScript
Utility type to reference JSDoc of another type
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Search Terms
type level jsdoc
computed jsdoc
reference jsdoc from other type
Suggestion
Add a utility type Docs<T>, which, given type T = U & Docs<V>, results in a type T with the type of U, but with the JSDoc annotations of V (overriding any U might have). This should also add V's go to definition results to T's (maybe prioritized?).
This could either be implemented as a magic type like ThisType (e.g. type Docs<T> = unknown in lib.d.ts), or as an intrinsic type, as introduced in #40580.
Use Cases
This is useful to preserve context when manipulating types (see example below).
Examples
interface Person {
id: string;
/**
* The date this person was born
*/
birthDate: Date;
/**
* The date this person died; `null` indicates that the person is still alive.
*/
deathDate: Date | null;
/**
* This person's age in milliseconds. Calculated as `deathDate - birthDate`
* when dead (`deathDate === null`), `currentDate - birthDate` when not.
*/
age: number;
name: string;
}
const alice: Person = {
id: "12345",
birthDate: new Date(),
deathDate: null,
age: 0,
name: "Alice"
};
alice.deathDate // Hover `deathDate`; we can clearly see what this field means and why it might be null
type Lazy<T> = {
[K in keyof T & string as `get${Capitalize<K>}`]: () => Promise<T[K]>
// Proposed syntax:
// [K in keyof T & string as `get${Capitalize<K>}`]: (() => Promise<T[K]>) & Docs<T[K]>
}
type LazyPerson = Lazy<Person>;
declare const getLazyPerson: (id: string) => LazyPerson;
const bob = getLazyPerson("1111");
bob.getDeathDate // Hover `getDeathDate`; we've lost all information about what this field means. Why could it be null?
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the proposed Docs<T> declaration in lib.d.ts and read issue #40580 for the intrinsic-type approach. Trace how the type system and language service represent JSDoc and go-to-definition results; done means the proposed type preserves V's documentation and adds its definition results to T as shown in the example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100