microsoft / microsoft/TypeScript
Instance member function becomes instance member property in mapped types
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Go
- Estrellas
- 111k
- Forks
- 14.3k
- Merge medio
- 2 d 4 h
- PR fusionados (30 d)
- 132
Descripción
TypeScript Version: 4.0.0-dev.20200512
Search Terms:
- instance member function becomes instance member property
- mixin property of exported class expression may not be private or protected
Code
export class Application {
protected getState() {
return 'starting';
}
component(componentCtor: typeof Object) {
// mount the component
}
}
// Ideally, I'd like to write `function repositoryMixin(superClass: typeof Application)`, but that
// triggers "property of exported class expression may not be private or protected"
export function repositoryMixin<T extends MixinTarget<Application>>(superClass: T) {
return class extends superClass {
component(componentCtor: typeof Object) {
super.component(componentCtor);
// register repositories contributed by the component
}
}
}
// helpers to work around TypeScript limitations related to mixins
export type Constructor<T extends object> = new (...args: any[]) => T;
export type MixinTarget<T extends object> = Constructor<
{
// Enumerate only public members to avoid the following compiler error:
// Property '(some-name)' of exported class expression
// may not be private or protected. ts(4094)
[p in keyof T]: T[p];
}
>;
Expected behavior:
The code compiles cleanly.
Actual behavior:
$ tsc mixin-bug.ts
mixin-bug.ts:13:5 - error TS2425: Class '{ component: (componentCtor: ObjectConstructor) => void; }' defines instance member property 'component', but extended class '(Anonymous class)' defines it as instance member function.
13 component(componentCtor: typeof Object) {
~~~~~~~~~
mixin-bug.ts:14:13 - error TS2340: Only public and protected methods of the base class are accessible via the 'super' keyword.
14 super.component(componentCtor);
~~~~~~~~~
Found 2 errors.
Playground Link:
Related Issues:
- Remove property-override-method error #34494
- 3.7: instance member function becomes instance member property in type references [outcome: fixed since 3.7.0-dev.20191016] #33747
- Support for all type features in declaration files. #35822
- False error TS4094: ... exported class expression may not be private or protected. #30355
- Allow .d.ts files to represent anonymous class expressions with
privatemembers #36060 - Unexpected TS4094 with the build parameter
declaration: true#17293 - Generating type definitions for mixin classes with protected members #17744
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Reproduce el comportamiento notificado en mixin-bug.ts usando el ejemplo enlazado de TypeScript Playground y compara los diagnósticos TS2425 y TS2340 con la compilación limpia esperada. Investiga las rutas del compilador que gestionan mapped types, mixin class expressions y la clasificación de miembros de método/propiedad; se considera terminado cuando el ejemplo compile sin esos errores.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- typescript
- Área
- compilers
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100