microsoft / microsoft/TypeScript
Instance member function becomes instance member property in mapped types
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Go
- Sterne
- 111k
- Forks
- 14.3k
- Ø Merge
- 2 T. 4 Std.
- Gemergte PRs (30 T.)
- 132
Beschreibung
TypeScript Version: 4.0.0-dev.20200512
Search Terms:
- instance member function becomes instance member property
- mixin property of exported class expression may not be private or protected
Code
export class Application {
protected getState() {
return 'starting';
}
component(componentCtor: typeof Object) {
// mount the component
}
}
// Ideally, I'd like to write `function repositoryMixin(superClass: typeof Application)`, but that
// triggers "property of exported class expression may not be private or protected"
export function repositoryMixin<T extends MixinTarget<Application>>(superClass: T) {
return class extends superClass {
component(componentCtor: typeof Object) {
super.component(componentCtor);
// register repositories contributed by the component
}
}
}
// helpers to work around TypeScript limitations related to mixins
export type Constructor<T extends object> = new (...args: any[]) => T;
export type MixinTarget<T extends object> = Constructor<
{
// Enumerate only public members to avoid the following compiler error:
// Property '(some-name)' of exported class expression
// may not be private or protected. ts(4094)
[p in keyof T]: T[p];
}
>;
Expected behavior:
The code compiles cleanly.
Actual behavior:
$ tsc mixin-bug.ts
mixin-bug.ts:13:5 - error TS2425: Class '{ component: (componentCtor: ObjectConstructor) => void; }' defines instance member property 'component', but extended class '(Anonymous class)' defines it as instance member function.
13 component(componentCtor: typeof Object) {
~~~~~~~~~
mixin-bug.ts:14:13 - error TS2340: Only public and protected methods of the base class are accessible via the 'super' keyword.
14 super.component(componentCtor);
~~~~~~~~~
Found 2 errors.
Playground Link:
Related Issues:
- Remove property-override-method error #34494
- 3.7: instance member function becomes instance member property in type references [outcome: fixed since 3.7.0-dev.20191016] #33747
- Support for all type features in declaration files. #35822
- False error TS4094: ... exported class expression may not be private or protected. #30355
- Allow .d.ts files to represent anonymous class expressions with
privatemembers #36060 - Unexpected TS4094 with the build parameter
declaration: true#17293 - Generating type definitions for mixin classes with protected members #17744
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Reproduziere das gemeldete Verhalten in mixin-bug.ts anhand des verknüpften TypeScript Playground-Beispiels und vergleiche die Diagnosen TS2425 und TS2340 mit der erwarteten fehlerfreien Kompilierung. Untersuche die Compiler-Pfade, die mapped types, mixin class expressions und die Klassifizierung von Methoden-/Property-Mitgliedern verarbeiten; abgeschlossen ist die Aufgabe, wenn das Beispiel ohne diese Fehler kompiliert.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- typescript
- Bereich
- compilers
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100