WebGLShader has no properties

Open
#35,696 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
28/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
typescript
Domain
compilers

Research direction

Start with the examples in src/index.ts at lines 63-64 and 146, then reproduce the reported behavior using the linked TypeScript Playground. Compare the inferred Error return types and argument checking for loadShader and createProgram; done means the function arguments are enforced and the expected return types are inferred correctly.

Written by the indexing model from the issue text.

Description

Bug Domain: lib.d.ts

TypeScript Version: 3.7.3

Search Terms: array element type checking, error type checking, stops checking function argument types

Code
https://github.com/vjancik/dont-find-me-yet/blob/tsc-issue/src/index.ts#L63-L64

  • fails to infer a possible Error type
  • and if I set it explicitly (see Playground), fails to enforce it in

https://github.com/vjancik/dont-find-me-yet/blob/tsc-issue/src/index.ts#L146

  • createProgram doesn't enforce WebGLShader[] at all on the first argument, or seemingly any of the other arguments as well. I can add any variable in there and the array accepts it (also Playground)

Expected behavior:
Types of fn. arguments on createProgram get enforced correctly.
Optional: Return type on loadShader & createProgram gets inferred correctly as ... | Error

Actual behavior:
The issue doesn't resolve even if I specify all return types on all functions manually.

Playground Link:
Playground link

Related Issues:
No, there are multiple problems and I can't pinpoint the cause in a very specific setup.

Dominant language
Go
Stars
111k
Forks
14.4k
Avg merge
1d 19h
Merged PRs (30d)
117

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/TypeScript

All issues in microsoft/TypeScript

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.