microsoft / microsoft/TypeScript
Generic enumerated type parameter narrowing (conditional types)
Nessuno ha ancora preso questa issue.
- Lingua principale
- Go
- Stelle
- 111k
- Fork
- 14.3k
- Merge medio
- 2g 4h
- PR unite (30g)
- 132
Descrizione
Search Terms
conditional type inference enum enumerated narrowing branching generic parameter type guard
Suggestion
Improve inference / narrowing for a generic type parameter and a related conditional type.
I saw another closed-wontfix issue requesting generic parameter type guards, but a type guard should not be necessary for this case, since the possible values for the generic are enumerated.
Use Cases
(Names have been changed and simplified)
I have a method that takes a KeyType (enumerated) and a KeyValue with type conditionally based on the enumerated KeyType.
Depending on the KeyType value, the code calls method(s) specific to that type.
The TS compiler is unable to tell that after I have checked the enumerated KeyType, the type of the KeyValue (string, number, etc) is known and should be able to be passed to a function that only accepts that specific KeyValue type.
Examples
const enum TypeEnum {
String = "string",
Number = "number",
Tuple = "tuple"
}
// The issue also occurs with
// type TypeEnum = "string" | "number" | "tuple"
interface KeyTuple { key1: string; key2: number; }
type KeyForTypeEnum<T extends TypeEnum>
= T extends TypeEnum.String ? string
: T extends TypeEnum.Number ? number
: T extends TypeEnum.Tuple ? KeyTuple
: never;
class DoSomethingWithKeys {
doSomethingSwitch<TType extends TypeEnum>(type: TType, key: KeyForTypeEnum<TType>) {
switch (type) {
case TypeEnum.String: {
this.doSomethingWithString(key);
break;
}
case TypeEnum.Number: {
this.doSomethingWithNumber(key);
break;
}
case TypeEnum.Tuple: {
this.doSomethingWithTuple(key);
break;
}
}
}
doSomethingIf<TType extends TypeEnum>(type: TType, key: KeyForTypeEnum<TType>) {
if (type === TypeEnum.String) {
this.doSomethingWithString(key);
}
else if (type === TypeEnum.Number) {
this.doSomethingWithNumber(key);
}
else if (type === TypeEnum.Tuple) {
this.doSomethingWithTuple(key);
}
}
private doSomethingWithString(key: string) {
}
private doSomethingWithNumber(key: number) {
}
private doSomethingWithTuple(key: KeyTuple) {
}
}
This should compile without errors if TS was able to tell that the switch statements or equality checks limited the possible type of the other property.
I lose a lot of the benefits of TS if I have to cast the value to something else. especially if I have to cast as any as KeyForTypeEnum<TType> as has happened in my current codebase.
If I'm doing something wrong or if there's already a way to handle this, please let me know.
Checklist
My suggestion meets these guidelines:
[X] This wouldn't be a breaking change in existing TypeScript / JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. new expression-level syntax)
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia riproducendo l'esempio fornito di tipo condizionale generico e individua i test esistenti del compilatore TypeScript per il narrowing generico e i tipi condizionali; la issue non indica file o test specifici. Il lavoro è completato quando rami equivalenti di switch e di verifica di uguaglianza compilano senza casts mantenendo il comportamento esistente.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- typescript
- Ambito
- compilers
- Tipo di issue
- Funzionalità
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Stato di attività
- Ferma
- Chiarezza
- Specificata chiaramente
- Idoneità per principianti
- 28/100