Regular Expressions StartMatch is not NumberIsFloat aware, always uses Float

Open
#1,816 0 comments 0 reactions 1 assignee View on GitHub

@gregli-msft is already working on this.

Since Sep 7, 2023.

Assessment

This issue has not been assessed yet.

Description

Before we GA this functionality, we should examine if this field of the return record/table should be Decimal for NumberIsFloat=false hosts. The argument for decmimal is that it is consistent and doesn't taint calculations as decimal has a lower type precedence than float. But on first look, plumbing numberIsFloat inforamtion down in the interpreter, as these functions are async, was going to be non-trivial.

Dominant language
C#
Stars
3.4k
Forks
358
Avg merge
10h 34m
Merged PRs (30d)
3

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/Power-Fx

All issues in microsoft/Power-Fx

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.