microsoft / microsoft/Power-Fx
Make TestNl2FxIsCanceledCorrectly deterministic
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.4k
- Forks
- 358
- Avg merge
- 10h 34m
- Merged PRs (30d)
- 3
Description
This is a flakey test. , failing here https://github.com/microsoft/Power-Fx/pull/2728/checks?check_run_id=33611576122
Anything with something like this CancelAfter(500) ms is going to be flaky.
Make it deterministic.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/tests/Microsoft.PowerFx.Interpreter.Tests.Shared/LanguageServiceProtocol/RedesignedLanguageServerTests/CancellationTests.cs at the TestNl2FxIsCanceledCorrectly test and inspect its CancelAfter(500) ms usage. Replace the timing-dependent behavior with a deterministic test, then run the relevant cancellation test to confirm it passes reliably.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100