microsoft / microsoft/BotFramework-DirectLineJS

Connection status Online when Websockets connection failing

Abierto
#432 0 comentarios 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Lenguaje dominante
TypeScript
Estrellas
199
Forks
133
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

We are using this library in our React app and I encounter this weird behaviour.

The problem

When disabled Websockets connection in Chrome browser using these steps:

  1. Open Chrome and install this extension
  2. Restart Chrome
  3. Go to the Extensions
  4. Click uBlock Origin, the dashboard window or popup should be viewed
  5. From the dashboard, click on Settings (cogs icon, see image above)
  6. In the settings go to My filters tab
  7. Add ||*^$websocket to 1st line of the filter editor and hit Apply changes

I can see that it successfully blocks the wss connections as I can see failed requests in my network tab. The problem is that the connection status will eventually set to ConnectionStatus.Online. I would expect that it will be ConnectionStatus.FailedToConnect as the Websockets request are failing. We need this so we can react with our UI to this scenario and also to log this to our internal logging systems. I cannot see how to do it without proper connection status information, though.

Our setup

In the React code we are just initializing my DirectLine instance in effect hook:

  useEffect(() => {
    if (directLineTokenData) {
      const body = {
        token: directLineTokenData.token || '',
        conversationId: conversationId || '',
        ...COMMON_BOT_PROPERTIES,
      };
      setDirectLine(new DirectLine(body));
    }
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [directLineTokenData]);

and in another we subscribe to the activity$ and connectionStatus$ observables:

 useEffect(() => {
    // eslint-disable-next-line no-console
    console.log('Starting subscription to all activities');
    const subscribtion = directLine?.activity$.subscribe(activity =>
      // eslint-disable-next-line no-console
      console.log('Received activity:', activity),
    );
    // eslint-disable-next-line no-console
    const connectionStatusSubscription = directLine?.connectionStatus$.subscribe(
      status => {
        switch (status) {
          case ConnectionStatus.Uninitialized:
            // eslint-disable-next-line no-console
            console.log('STATUS: uninitialized');
            break;
          case ConnectionStatus.Connecting:
            // eslint-disable-next-line no-console
            console.log('STATUS: connecting...');
            break;
          case ConnectionStatus.Online:
            // eslint-disable-next-line no-console
            console.log('STATUS: online');
            break;
          case ConnectionStatus.ExpiredToken:
            // eslint-disable-next-line no-console
            console.log('STATUS: expired token');
            break;
          case ConnectionStatus.FailedToConnect:
            // eslint-disable-next-line no-console
            console.log('STATUS: failed to connect');
            break;
          case ConnectionStatus.Ended:
            // eslint-disable-next-line no-console
            console.log('STATUS: ended');
            break;
          default:
            // eslint-disable-next-line no-console
            console.log('STATUS: unknown status', status);
        }
      },
      error => {
        // eslint-disable-next-line no-console
        console.error('Error subscribing to connection status', error);
      },
    );
    return () => {
      console.log('Stopping subscription to all activities');

      subscribtion?.unsubscribe();
      connectionStatusSubscription?.unsubscribe();
    };
  }, [directLine]);
Observing the problem

Console logs from our React app:

Image

From the logs we can see that there is eventually a ConnectionStatus.Online connection status change, even though failing Websockets requests. What's interesting that it sets connection status to ConnectionStatus.FailedToConnect one time (before it is set to ConnectionStatus.Online)

Any help is appreciated 🙏

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Reproduce el problema en la configuración de React bloqueando las solicitudes WebSocket con el filtro documentado de uBlock Origin y, a continuación, observe connectionStatus$ de DirectLine junto con activity$. Empiece siguiendo el ciclo de vida del constructor de DirectLine y de connectionStatus$; el trabajo estará terminado cuando una conexión wss que falla persistentemente informe ConnectionStatus.FailedToConnect en lugar de terminar convirtiéndose en Online.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
react, typescript
Área
api, networking
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Necesita aclaración
Aptitud para principiantes
30/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.