microsoft / microsoft/BotFramework-DirectLineJS

Connection status Online when Websockets connection failing

Offen
#432 0 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Vorherrschende Sprache
TypeScript
Sterne
199
Forks
133
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

We are using this library in our React app and I encounter this weird behaviour.

The problem

When disabled Websockets connection in Chrome browser using these steps:

  1. Open Chrome and install this extension
  2. Restart Chrome
  3. Go to the Extensions
  4. Click uBlock Origin, the dashboard window or popup should be viewed
  5. From the dashboard, click on Settings (cogs icon, see image above)
  6. In the settings go to My filters tab
  7. Add ||*^$websocket to 1st line of the filter editor and hit Apply changes

I can see that it successfully blocks the wss connections as I can see failed requests in my network tab. The problem is that the connection status will eventually set to ConnectionStatus.Online. I would expect that it will be ConnectionStatus.FailedToConnect as the Websockets request are failing. We need this so we can react with our UI to this scenario and also to log this to our internal logging systems. I cannot see how to do it without proper connection status information, though.

Our setup

In the React code we are just initializing my DirectLine instance in effect hook:

  useEffect(() => {
    if (directLineTokenData) {
      const body = {
        token: directLineTokenData.token || '',
        conversationId: conversationId || '',
        ...COMMON_BOT_PROPERTIES,
      };
      setDirectLine(new DirectLine(body));
    }
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [directLineTokenData]);

and in another we subscribe to the activity$ and connectionStatus$ observables:

 useEffect(() => {
    // eslint-disable-next-line no-console
    console.log('Starting subscription to all activities');
    const subscribtion = directLine?.activity$.subscribe(activity =>
      // eslint-disable-next-line no-console
      console.log('Received activity:', activity),
    );
    // eslint-disable-next-line no-console
    const connectionStatusSubscription = directLine?.connectionStatus$.subscribe(
      status => {
        switch (status) {
          case ConnectionStatus.Uninitialized:
            // eslint-disable-next-line no-console
            console.log('STATUS: uninitialized');
            break;
          case ConnectionStatus.Connecting:
            // eslint-disable-next-line no-console
            console.log('STATUS: connecting...');
            break;
          case ConnectionStatus.Online:
            // eslint-disable-next-line no-console
            console.log('STATUS: online');
            break;
          case ConnectionStatus.ExpiredToken:
            // eslint-disable-next-line no-console
            console.log('STATUS: expired token');
            break;
          case ConnectionStatus.FailedToConnect:
            // eslint-disable-next-line no-console
            console.log('STATUS: failed to connect');
            break;
          case ConnectionStatus.Ended:
            // eslint-disable-next-line no-console
            console.log('STATUS: ended');
            break;
          default:
            // eslint-disable-next-line no-console
            console.log('STATUS: unknown status', status);
        }
      },
      error => {
        // eslint-disable-next-line no-console
        console.error('Error subscribing to connection status', error);
      },
    );
    return () => {
      console.log('Stopping subscription to all activities');

      subscribtion?.unsubscribe();
      connectionStatusSubscription?.unsubscribe();
    };
  }, [directLine]);
Observing the problem

Console logs from our React app:

Image

From the logs we can see that there is eventually a ConnectionStatus.Online connection status change, even though failing Websockets requests. What's interesting that it sets connection status to ConnectionStatus.FailedToConnect one time (before it is set to ConnectionStatus.Online)

Any help is appreciated 🙏

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Reproduzieren Sie das Problem im React-Setup, indem Sie WebSocket-Anfragen mit dem dokumentierten uBlock Origin-Filter blockieren, und beobachten Sie anschließend DirectLines connectionStatus$ zusammen mit activity$. Beginnen Sie damit, den Lebenszyklus des DirectLine-Konstruktors und von connectionStatus$ nachzuverfolgen; als abgeschlossen gilt die Aufgabe, wenn eine dauerhaft fehlschlagende wss-Verbindung ConnectionStatus.FailedToConnect meldet, anstatt schließlich Online zu werden.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
react, typescript
Bereich
api, networking
Issue-Typ
Bug
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Muss geklärt werden
Anfängerfreundlichkeit
30/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.