mapstruct / mapstruct/mapstruct-idea

Wrong usage of mappers factory should be able to remove static initializer

Open
#183 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
168
Forks
41
PR merge metrics
No merged PRs in 30d

Description

Why reviewing PR #179 @hduelme pointed out that the Wrong usage of mappers factory does not work (i.e. it does not remove it) with the following code:

```java
@Mapper(componentModel = "spring")
abstract class WrongComponentModelMapper {

static {
Mappers.getMapper(WrongComponentModelMapper.class);
}

Target map(Target source);
}
```

or
```java
@Mapper(config = MyConfig.class, componentModel = "spring")
interface WrongComponentModelMapper {

WrongComponentModelMapper INSTANCE = () -> {
return Mappers.getMapper(WrongComponentModelMapper.class);
};

Target map(Target source);
}
```

We need to see if we can support this.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the static-initializer and interface-field examples from the issue and tracing how the IntelliJ plugin currently handles Mappers.getMapper usage. Check the discussion around PR #179 for context. Done means determining whether these patterns can be supported and, if so, validating the behavior with coverage for both examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.