mapbox / mapbox/node-cpp-skel

Investigate use of Global instead of Persistent

Open
#96 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
74
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Currently we only use `Nan::Persistent` which requires that we call `Reset()` prior to the objects destruction or the object will never be garbage collected. `Nan::Global` is an alternative that provides automatically calls reset at the time of destruction of the hander.

Contributor guide

Open the contributing guide

Research direction

Start by locating the uses of Nan::Persistent and reviewing how each object is destroyed. Compare those lifecycles with Nan::Global's automatic reset behavior. Done means determining whether the usages can safely switch without leaving objects uncollected, and documenting or implementing the resulting change.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js
Domain
backend-api-design
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.