Wrong placement of annotation highlight

Open
#610 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
c
Domain
desktop

Research direction

Reproduce the issue in Xreader 3.8.2 on Linux Mint using continuous view and full page width, with part of page n-1 visible. Start by tracing the annotation and highlighting handling used by this view. Done means dragging the marker on page n-1 places the highlight there rather than on the next page.

Written by the indexing model from the issue text.

Description

 * Xreader version 3.8.2
 * Distribution - Linux Mint 21.2 Cinnamon

Issue
If the page you are highlighting covers less than half of the window, annotation doesn't follow the cursor and automatically happens on the next page. But if the page covers more than half the window, annotation happens on the correct location.

Steps to reproduce
(See the small demo video)

  1. Open a pdf with xreader
  2. In the view menu select "continuous" and "full page width".
  3. Scroll to page n, but make sure that some portion of page n-1 is also visible
  4. Select annotation on the sidebar, and select highlighting marker.
  5. Try to highlight anywhere on page n-1

Expected behaviour
Highlighting should happen where the cursor is dragging, not on the next page.

Other information
A small demo video ---

https://github.com/linuxmint/xreader/assets/25789626/129d21f8-7f15-480d-af97-6b3274954549

Dominant language
C
Stars
283
Forks
82
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from linuxmint/xreader

All issues in linuxmint/xreader

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.