Rotate shortcuts don't work if document overruns edge of reader

Open
#546 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
c
Domain
desktop

Research direction

Reproduce the issue in Xreader 2.8.3 on Linux 20.1 using the listed steps, then trace the handling for the Ctrl+right/left rotation shortcuts after rotating an oversized page. Done means both rotation shortcuts remain usable when the page length exceeds the reader width and the reproduction steps no longer show them disabled.

Written by the indexing model from the issue text.

Description

 * Xreader 2.8.3
 * Distribution: Linux 20.1

Issue

This is an issue I run into regularly. If you rotate a document page right or left so that it is now in a landscape orientation, the rotation shortcuts, Ctrl + right/left, are disabled if the width of the reader is less than the length of the doument.. IME, it is easy to press a rotation shortcut by mistake (perhaps thinking it is a next/previous page shortcut) in which case you cannot QUICKLY correct the mistake using the opposite rotation shortcut.

Steps to reproduce

  1. Open a pdf document.
  2. Set the width of the Xreader window so that it is narrower than the length of the document page.
  3. Rotate the page right or left.
  4. Now, try to use a rotation shortcut.

RESULT: The rotation shortcut is disabled.

Expected behaviour

The rotation shortcuts should still work even if the length of the document page is greater than the width of the reader.

Dominant language
C
Stars
283
Forks
82
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from linuxmint/xreader

All issues in linuxmint/xreader

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.