Feature request: Provide an option to allow toggling the toolbar in full-screen mode.

Open
#535 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
c
Domain
desktop

Research direction

Start with the referenced commit 917d52b9ed2975a5678cd42add7fc006ca8f4e60 and trace the full-screen toolbar handling for Ctrl+Shift+T. Review the Preferences window if implementing the configurable behavior. Done means the toolbar remains hidden by default in full-screen, the shortcut can reveal or toggle it, and the existing default behavior is preserved.

Written by the indexing model from the issue text.

Description

 * Xreader version (xreader 3.2.2)
 * Distribution - (Mint 20.3)

Issue
The toolbar can no longer be toggled in full-screen mode.

Steps to reproduce
Activate full-screen, then press Ctrl+Shift+T.

Expected behavior
There was a recent change https://github.com/linuxmint/xreader/commit/917d52b9ed2975a5678cd42add7fc006ca8f4e60 that disabled the toolbar in full-screen mode. The reasoning is valid, however if the toolbar is needed (to navigate to a specific page because many old datasheets don't have an index), one must now exit full-screen, use the toolbar, then enter full-screen again, versus the old Ctrl+Shift+T.

Would it be possible to hide the toolbar by default when entering full-screen but still allow using Ctrl+Shift+T afterwards?

Or even better, to add an option in the Preferences window to bring back the old behavior while keeping the current one as the default?

Thank you!

Dominant language
C
Stars
283
Forks
82
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from linuxmint/xreader

All issues in linuxmint/xreader

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.