Explain bookmarks a bit more please

Open
#372 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
c
Domain
desktop

Research direction

No source files or tests are named. Start by reproducing the bookmark behavior described in the issue and read the author's follow-up posts, since the initial diagnosis was retracted; done means establishing the corrected behavior and addressing it without relying on that diagnosis.

Written by the indexing model from the issue text.

Description

FEATURE REQUEST 
 * Xreader version (xreader --version): 2.4.4 
 * Distribution - (Mint 17.2, Arch, Fedora 25, etc...): Mint Cinnamon 19.3

Issue
Bookmarks are lost without warning when a PDF is closed. I have found by trial and error that if you "save a copy" of the PDF, then the bookmarks are saved too, for the next session. This is not obvious or documented.

Steps to reproduce
Make a bookmark, then close the PDF.

Expected behaviour
Warning that bookmarks will be lost, and a suggestion to "save a copy" of your PDF.

[Edit of 4 March 2020]
The above is not quite right. I had not correctly diagnosed the behaviour of bookmarks. See my further posts below.

Dominant language
C
Stars
283
Forks
82
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from linuxmint/xreader

All issues in linuxmint/xreader

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.