Incorrectly decoded strings in Repository.path and Repository.workdir when using Python 3 on Windows

Example:

>import pygit2
>import sys
>r = pygit2.init_repository(r"C:\repösitory")
>r.path
'C:/repösitory/.git/' # this is a wrongly decoded path
>r.path.encode(sys.getfilesystemencoding()).decode("utf-8") # workaround
'C:/repösitory/.git/' # this looks right

Reproduced with "pygit2-0.28.2-cp35-cp35m-win32.whl".

The problem seems to be in "repository.c", function "Repository_path__get__":

return to_path(git_repository_path(self->repo));

The "to_path" function assumes that libgit2 returns a byte string with file system encoding:

#define to_path(x) to_unicode(x, Py_FileSystemDefaultEncoding, "strict")

But libgit2 actually returns a byte string encoded in UTF-8.
Maybe the behaviour of libgit2 has changed at some point?

非 ASCII 文字を含むリポジトリパスを使って Python 3 の Windows 例を再現し、その後 repository.c、特に Repository_path__get__ と to_path の定義を調べます。Repository.path と Repository.workdir の両方を確認し、返されるパスが文書化されている回避策なしで元の文字を保持していることを検証します。