Repository.IsValid leaking memory

Open
#1,366 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp, git
Domain
tooling

Research direction

Start by reproducing repeated Repository.IsValid calls in a long-running tool and inspect the implementation of that entry point. Confirm the suspected leak with memory measurements and verify that memory no longer grows during regular validity checks.

Written by the indexing model from the issue text.

Description

I have developed some tools to help the team I work with conform to our development process. One of the tools checks the validity of a repository regularly, and I have noticed that the call to Repository.IsValid leaks memory. As our tools are running all of the time this is a big issue!

If I manage to find some time I will take a look at the source code.

Phil.

(Renishaw plc, UK)

Dominant language
C#
Stars
3.5k
Forks
925
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from libgit2/libgit2sharp

All issues in libgit2/libgit2sharp

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.