jamulussoftware / jamulussoftware/jamulus
Manage settings with structs
- Lingua principale
- C
- Stelle
- 1.1k
- Fork
- 248
- Merge medio
- 2g 3h
- PR unite (30g)
- 9
Descrizione
(Yes, I'm still trying to sort this out...)
My mind's eye view is that the server has a set of settings: SServerSettings. This is _everything_ the server needs to know.
On start up, the structure is created (in main.cpp, defined in server.h).
Then, if GUI-enabled, CSettings populates it with values from the inifile - hence CSettings doesn't get passed a server instance any more - the server doesn't yet exist.
Next, all the values collected from the command line overwrite the appropriate entry in the settings structure.
And then finally, CServer gets instantiated with the SServerSettings instance reference.
To change a server setting, you call the server as you do now and it records that value in SServerSettings&.
When the server terminates, if GUI-enabled, CSettings is passed the SServerSettings reference to store to the inifile.
----
It's actually a fairly straight forward change in the server. The only concern I have when it comes to the client code... it isn't anywhere near as simple a model. Much of what's in the inifile isn't even for the client. So I'd keep the SClientSettings struct "unpolluted", free of GUI settings, perhaps having a separate SClientGUISettings for those.
----
One benefit is dropping all that code I added checking for command line options to prevent the inifile being used. The logic above handles that without any effort.
It could also help make it clear on what will persist to the inifile -- if it's not in one of the structs, it's not getting saved.
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Inizia tracciando il flusso di avvio in main.cpp e la definizione delle impostazioni del server in server.h, quindi esamina come CSettings, CServer e le impostazioni del client scambiano attualmente i valori. L’implementazione delle strutture di impostazioni proposte dovrebbe fare in modo che i valori della riga di comando sovrascrivano i valori di configurazione e preservare le impostazioni previste durante l’arresto, mantenendo separate le impostazioni della GUI del client.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- cpp
- Ambito
- backend, desktop
- Tipo di issue
- Refactoring
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 25/100