stop parsing symbol only ends at end of line, but pipe character is also acceptable

オープン
#144 コメント 6 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
45/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
停滞
技術スタック
powershell
領域
tooling

調査の方向性

Start with the PowerShell tmLanguage stop-parsing rule shown in the issue and compare it with the about_Parsing behavior. Verify that parsing ends at a pipe only when the pipe is outside double-quoted constructs, while the existing end-of-line behavior remains unchanged.

索引モデルが issue の本文から書いたものです。

説明

Environment
  • Editor and Version: VS Code: 1.26.1
  • Your primary theme: Monokai Dimmed
Issue Description

the stop parsing symbol, --% is set to scope all the way to the end of the line. I thought this was how the symbol worked as well, until I reread the doc on the matter (about_Parsing) and instead, it also can be terminated by the pipe character, but only if the pipe would be outside of any double-quoted constructs, as I have determined.

Its also possible to use environment variable substitution using the CMD `%variable% syntax, but if your environment variable name contains a double-quote, PowerShell processes it first, before the substitution has occurred (if it even occurs, as just like in CMD, if the variable is not found, the substitution does not occur), so its actually impossible to determine a real variable reference.

Expected Behavior

Syntax should at least support stop-parsing symbol's scope ending at a pipe, in the same manner as PowerShell actually does.

Possible tmLanguage modification:

{
	"begin": "(?<!\\w)(--%)(?!\\w)",
	"beginCaptures": {
		"1": {
			"name": "keyword.control.powershell"
		}
	},
	"end": "$|\\|",
	"patterns": [
		{
			"match": "[^\"\\x{201C}\\x{201D}]+?",
			"name": "string.unquoted.powershell"
		},
		{
			"begin": "(?:\"|\\x{201C}|\\x{201D})",
			"beginCaptures": {
				"0": {
					"name": "punctuation.definition.string.begin.powershell"
				}
			},
			"end": "(?:\"|\\x{201C}|\\x{201D})(?!\"|\\x{201C}|\\x{201D})|$",
			"endCaptures": {
				"0": {
					"name": "punctuation.definition.string.end.powershell"
				}
			},
			"name": "string.quoted.double.powershell"
		}
	],
	"comment": "This should be moved to the repository at some point."
},

I have the Unicode double-quotes included, as I determined that PowerShell treats them the same here as well as elsewhere.

I do have the intention of putting this in a PR.

主要言語
PowerShell
スター
151
フォーク
55
PR マージ指標
30日以内にマージされた PR はありません

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

PowerShell/EditorSyntax のほかの issue

PowerShell/EditorSyntax の issue をすべて見る

似ている issue

DevTools の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。