stop parsing symbol only ends at end of line, but pipe character is also acceptable
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 45/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Estancado
- Stack tecnológico
- powershell
- Área
- tooling
Línea de trabajo
Start with the PowerShell tmLanguage stop-parsing rule shown in the issue and compare it with the about_Parsing behavior. Verify that parsing ends at a pipe only when the pipe is outside double-quoted constructs, while the existing end-of-line behavior remains unchanged.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Environment
- Editor and Version: VS Code: 1.26.1
- Your primary theme: Monokai Dimmed
Issue Description
the stop parsing symbol, --% is set to scope all the way to the end of the line. I thought this was how the symbol worked as well, until I reread the doc on the matter (about_Parsing) and instead, it also can be terminated by the pipe character, but only if the pipe would be outside of any double-quoted constructs, as I have determined.
Its also possible to use environment variable substitution using the CMD `%variable% syntax, but if your environment variable name contains a double-quote, PowerShell processes it first, before the substitution has occurred (if it even occurs, as just like in CMD, if the variable is not found, the substitution does not occur), so its actually impossible to determine a real variable reference.
Expected Behavior
Syntax should at least support stop-parsing symbol's scope ending at a pipe, in the same manner as PowerShell actually does.
Possible tmLanguage modification:
{
"begin": "(?<!\\w)(--%)(?!\\w)",
"beginCaptures": {
"1": {
"name": "keyword.control.powershell"
}
},
"end": "$|\\|",
"patterns": [
{
"match": "[^\"\\x{201C}\\x{201D}]+?",
"name": "string.unquoted.powershell"
},
{
"begin": "(?:\"|\\x{201C}|\\x{201D})",
"beginCaptures": {
"0": {
"name": "punctuation.definition.string.begin.powershell"
}
},
"end": "(?:\"|\\x{201C}|\\x{201D})(?!\"|\\x{201C}|\\x{201D})|$",
"endCaptures": {
"0": {
"name": "punctuation.definition.string.end.powershell"
}
},
"name": "string.quoted.double.powershell"
}
],
"comment": "This should be moved to the repository at some point."
},
I have the Unicode double-quotes included, as I determined that PowerShell treats them the same here as well as elsewhere.
I do have the intention of putting this in a PR.
- Lenguaje dominante
- PowerShell
- Estrellas
- 151
- Forks
- 55
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de PowerShell/EditorSyntax
-
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
PowerShell/EditorSyntax#224 · 2 comentarios ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
PowerShell/EditorSyntax#222 · 2 comentarios ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
PowerShell/EditorSyntax#221 · 2 comentarios ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 45/100
PowerShell/EditorSyntax#220 · 2 comentarios · 1 reacción ·
-
Issue-Bug
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
PowerShell/EditorSyntax#219 · 2 comentarios ·
Todos los issues de PowerShell/EditorSyntax
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
0xMiden/bridge-portal#132 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
newrelic-experimental/preflight#793 · 1 comentario ·
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
babalae/bettergi-scripts-list#3674 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
caddyserver/caddy#8046 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
zilliztech/memsearch#759 ·