Question / Guidance: MinIO Implementation

Aperta
#108 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Da chiarire
Stato di attività
Ferma
Stack tecnologico
csharp
Ambito
backend, cloud

Direzione di ricerca

Iniziare confrontando il MSBuildCacheMinioStoragePlugin.cs proposto con l’implementazione di AzureBlobStorage ed esaminare le interfacce ICacheClient, IContentStore, IContentSession, IMetadataStore, IPublishingStore e quelle correlate di BuildXL. Determinare quali componenti della cache MinIO siano effettivamente necessari, quindi documentare un ambito di implementazione definito e un approccio ai test.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

After reading more about MSBuildCache and BuildXL I wanted to ask a few questions to see if implementing MinIO as a cache is feasible and at what level it should be implemented.

  • Is the expectation of this repository to hide the internals of BuildXL? The reason I ask is BuildXL seems to be on GitHub but has a decent amount of internal vs public stuff going on. Not clear to me if extending functionality from that repository is recommended.
  • If it is recommended to extend functionality from that repository any guidance on a Minio approach? This is what I've currently got in my notes so far:
    • Use AzureBlobStorage as an example.
    • Careful of classes that seem generic but have Azure specific functionality. May not be able to re-use as much as initially hoped.
    • Create MSBuildCacheMinioStoragePlugin.cs
    • MSBuildCacheMinioStoragePlugin.cs will implement CreateCacheClientAsync that returns a CasCacheClient to satisfy ICacheClient requirement.
    • The CasCacheClient expects a local cache and remote cache. The local cache is already handled. The remote cache must be a Minio compatible remote cache implementation.
    • To create a Minio compatible remote cache client we must implement:
      • MinioContentStore to satisfy IContentStore requirement.
      • MinioContentSession to satisfy IContentSession requirement.
      • MinioContentStore and MinioContentSession will be injected into OneLevelCache and "just work" given those new Minio classes are implemented correctly.
      • MinioMetadataStore to satisfy IMetadataStore requirement.
      • MinioMetadataStore will be injected into MetadataStoreMemoizationDatabase. DatabaseMemoizationStore will "just work" given new Minio classes are implemented correctly.
      • IPublishingStore and IPublishingSession looks like they need to be implemented but ran out of time during investigation. Look later to determine requirements.
      • IBlobCacheTopology does not seem required but might want to mimic flow anyways to keep things the same.
    • Overall very involved. Overhead of learning BuildXL is very high. Testing / debuggability also seems difficult.

Does everything around BuildXL and having to extend that sound correct if we want a Minio / S3 implementation? Am I overstating or understating how involved this is?

Any guidance would be appreciated!

Lingua principale
C#
Stelle
64
Fork
24
Merge medio
1g 14h
PR unite (30g)
2

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di microsoft/MSBuildCache

Tutte le issue di microsoft/MSBuildCache

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.