Question / Guidance: MinIO Implementation

Abierto
#108 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Necesita aclaración
Estado de actividad
Estancado
Stack tecnológico
csharp
Área
backend, cloud

Línea de trabajo

Comience comparando el MSBuildCacheMinioStoragePlugin.cs propuesto con la implementación de AzureBlobStorage e inspeccione las interfaces ICacheClient, IContentStore, IContentSession, IMetadataStore, IPublishingStore y las relacionadas de BuildXL. Determine qué componentes de caché de MinIO son realmente necesarios y, a continuación, documente un alcance de implementación definido y un enfoque de pruebas.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

After reading more about MSBuildCache and BuildXL I wanted to ask a few questions to see if implementing MinIO as a cache is feasible and at what level it should be implemented.

  • Is the expectation of this repository to hide the internals of BuildXL? The reason I ask is BuildXL seems to be on GitHub but has a decent amount of internal vs public stuff going on. Not clear to me if extending functionality from that repository is recommended.
  • If it is recommended to extend functionality from that repository any guidance on a Minio approach? This is what I've currently got in my notes so far:
    • Use AzureBlobStorage as an example.
    • Careful of classes that seem generic but have Azure specific functionality. May not be able to re-use as much as initially hoped.
    • Create MSBuildCacheMinioStoragePlugin.cs
    • MSBuildCacheMinioStoragePlugin.cs will implement CreateCacheClientAsync that returns a CasCacheClient to satisfy ICacheClient requirement.
    • The CasCacheClient expects a local cache and remote cache. The local cache is already handled. The remote cache must be a Minio compatible remote cache implementation.
    • To create a Minio compatible remote cache client we must implement:
      • MinioContentStore to satisfy IContentStore requirement.
      • MinioContentSession to satisfy IContentSession requirement.
      • MinioContentStore and MinioContentSession will be injected into OneLevelCache and "just work" given those new Minio classes are implemented correctly.
      • MinioMetadataStore to satisfy IMetadataStore requirement.
      • MinioMetadataStore will be injected into MetadataStoreMemoizationDatabase. DatabaseMemoizationStore will "just work" given new Minio classes are implemented correctly.
      • IPublishingStore and IPublishingSession looks like they need to be implemented but ran out of time during investigation. Look later to determine requirements.
      • IBlobCacheTopology does not seem required but might want to mimic flow anyways to keep things the same.
    • Overall very involved. Overhead of learning BuildXL is very high. Testing / debuggability also seems difficult.

Does everything around BuildXL and having to extend that sound correct if we want a Minio / S3 implementation? Am I overstating or understating how involved this is?

Any guidance would be appreciated!

Lenguaje dominante
C#
Estrellas
64
Forks
24
Merge medio
1 d 14 h
PR fusionados (30 d)
2

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de microsoft/MSBuildCache

Todos los issues de microsoft/MSBuildCache

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.