WARP doesn't save varargs status of functions

Aperta
#7,929 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
cpp
Ambito
reverse-engineering

Direzione di ricerca

Start by reproducing the WARP Include Function, Create, and Load File flow described in the issue, then trace where the exported printf signature is serialized and reapplied. Done means a signature declared as void printf(char* format, ...); is restored with its varargs intact and the reported calling-convention analysis behavior is preserved.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Component: WARP Impact: Low

Version and Platform (required):

  • Binary Ninja Version: 5.3.9003-dev
  • Edition: Ultimate
  • OS: macOS
  • OS Version: 26.2
  • CPU Architecture: aarch64

Bug Description:
When I used WARP to save signatures for printf, and then used those signatures to match printf in a new file, the varargs portion of the arguments to printf was not applied. Notably, it gave printf the signature void printf(char* format); missing the varargs. The varargs are a critical part of the type signature, as they indicate to analysis that the remaining arguments (at least in my architecture's case) are passed via the stack and not registers.

Steps To Reproduce:

  1. Open a stripped binary containing printf
  2. Navigate to printf
  3. Name and type printf as void printf(char* format, ...);
  4. Use WARP > Include Function to mark printf for export
  5. WARP > Create > From Current View and set included functions to Selected
  6. WARP > Load File on the generated signatures you just saved
  7. Re-open stripped binary
  8. Observe printf is detected but now has the signature void printf(char* format); with no varargs

Expected Behavior:
I expected the function signature I specified to be saved as-is and for the varargs to be reapplied.

Additional Information:
Signatures were generated for a binary using a custom arch plugin which can be provided if requested

Lingua principale
C++
Stelle
1.3k
Fork
298
Merge medio
5g 5h
PR unite (30g)
19

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Vector35/binaryninja-api

Tutte le issue di Vector35/binaryninja-api

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.