WARP doesn't save varargs status of functions

Abierto
#7,929 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
cpp
Área
reverse-engineering

Línea de trabajo

Start by reproducing the WARP Include Function, Create, and Load File flow described in the issue, then trace where the exported printf signature is serialized and reapplied. Done means a signature declared as void printf(char* format, ...); is restored with its varargs intact and the reported calling-convention analysis behavior is preserved.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Component: WARP Impact: Low

Version and Platform (required):

  • Binary Ninja Version: 5.3.9003-dev
  • Edition: Ultimate
  • OS: macOS
  • OS Version: 26.2
  • CPU Architecture: aarch64

Bug Description:
When I used WARP to save signatures for printf, and then used those signatures to match printf in a new file, the varargs portion of the arguments to printf was not applied. Notably, it gave printf the signature void printf(char* format); missing the varargs. The varargs are a critical part of the type signature, as they indicate to analysis that the remaining arguments (at least in my architecture's case) are passed via the stack and not registers.

Steps To Reproduce:

  1. Open a stripped binary containing printf
  2. Navigate to printf
  3. Name and type printf as void printf(char* format, ...);
  4. Use WARP > Include Function to mark printf for export
  5. WARP > Create > From Current View and set included functions to Selected
  6. WARP > Load File on the generated signatures you just saved
  7. Re-open stripped binary
  8. Observe printf is detected but now has the signature void printf(char* format); with no varargs

Expected Behavior:
I expected the function signature I specified to be saved as-is and for the varargs to be reapplied.

Additional Information:
Signatures were generated for a binary using a custom arch plugin which can be provided if requested

Lenguaje dominante
C++
Estrellas
1.3k
Forks
298
Merge medio
5 d 5 h
PR fusionados (30 d)
19

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Vector35/binaryninja-api

Todos los issues de Vector35/binaryninja-api

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.