ipython / ipython/traitlets

Duplicate invocation of validate() on Configurable._load_config()

未关闭
#467 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
653
派生
217
平均合并
2 天 21 小时
30 天内合并 PR
2

描述

This simple code below on latest sources invokes `TraitType.validate()` twice. Beside a performance issue, this behavior forbids complex "converting" traits because the input value might be converted twice.
```python
import traitlets as trt, traitlets.config as trc

class C(trc.Configurable):
i=trt.CInt(config=True)

C(config=trc.Config({'C': {'i': '1'}})) ## CInt.validate() invoked twice with '1' & 1.
```

The reason is that `hold_trait_notifications()` context-manager in `_load_config()` re-sets the trait-value on exit (L1172): https://github.com/ipython/traitlets/blob/15319254d70d61cf667d28243933f541a9bbe75b/traitlets/traitlets.py#L1167-L1172

I would expect #390 to have fixed this.
- Is duplication on purpose?
- Is there something wrong with my understanding?

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。