ipython / ipython/traitlets

Duplicate invocation of validate() on Configurable._load_config()

Aperta
#467 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
653
Fork
217
Merge medio
2g 21h
PR unite (30g)
2

Descrizione

This simple code below on latest sources invokes `TraitType.validate()` twice. Beside a performance issue, this behavior forbids complex "converting" traits because the input value might be converted twice.
```python
import traitlets as trt, traitlets.config as trc

class C(trc.Configurable):
i=trt.CInt(config=True)

C(config=trc.Config({'C': {'i': '1'}})) ## CInt.validate() invoked twice with '1' & 1.
```

The reason is that `hold_trait_notifications()` context-manager in `_load_config()` re-sets the trait-value on exit (L1172): https://github.com/ipython/traitlets/blob/15319254d70d61cf667d28243933f541a9bbe75b/traitlets/traitlets.py#L1167-L1172

I would expect #390 to have fixed this.
- Is duplication on purpose?
- Is there something wrong with my understanding?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.