Instance trait type default value confusion
Đang mở
- Ngôn ngữ chính
- Python
- Star
- 653
- Fork
- 217
- Merge trung bình
- 2 ngày 21 giờ
- Pull request đã merge (30 ngày)
- 2
Mô tả
We raise here:
``` python
class A(HasTraits):
inst = Instance(Foo)
A().inst
```
But not here:
``` python
class A(HasTraits):
inst = Instance(Foo, allow_none=True)
A().inst
```
This seems magical, and is not at all implied by `allow_none=True`.
We should probably try to enforce this convention:
``` python
class A(HasTraits):
inst = Instance(Foo, default_value=None, allow_none=True)
A().inst
```
Or at the very least:
set `allow_none=True` if `default_value=None`
``` python
class A(HasTraits):
inst = Instance(Foo, default_value=None)
A().inst
```
This isn't backwards compatible, but IMO it resolves a bug.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.