ipython / ipython/ipykernel

Handling a comms message has side effects

未关闭
#432 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
734
派生
412
平均合并
1 天 5 小时
30 天内合并 PR
8

描述

When handling comms messages, the kernel calls `shell.events.trigger('pre_execute')` and `self.shell.callbacks.fire('post_execute')`. This limits the utility of comms messages as sending a comms message to the kernel has quite substantial side effects. For example, any pending matplotlib figure are plotted as soon as a comms message is received. I am using comms in spyder to communicate between the kernel and the frontend. Is there a reason why `pre/post_execute` need to be triggered when handling a generic comms message?
I am using monkey-patching to remove these calls in spyder, and I was wondering if this is something that should be fixed upstream.

Line for ref:
https://github.com/ipython/ipykernel/blob/97d10d4c9e0bd558c3b696e8cc51d23d3223a071/ipykernel/comm/comm.py#L161

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。