ipython / ipython/ipykernel

Handling a comms message has side effects

Aberta
#432 0 comentários 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
Python
Estrelas
734
Forks
412
Merge médio
1d 5h
PRs com merge (30d)
8

Descrição

When handling comms messages, the kernel calls `shell.events.trigger('pre_execute')` and `self.shell.callbacks.fire('post_execute')`. This limits the utility of comms messages as sending a comms message to the kernel has quite substantial side effects. For example, any pending matplotlib figure are plotted as soon as a comms message is received. I am using comms in spyder to communicate between the kernel and the frontend. Is there a reason why `pre/post_execute` need to be triggered when handling a generic comms message?
I am using monkey-patching to remove these calls in spyder, and I was wondering if this is something that should be fixed upstream.

Line for ref:
https://github.com/ipython/ipykernel/blob/97d10d4c9e0bd558c3b696e8cc51d23d3223a071/ipykernel/comm/comm.py#L161

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.