ipython / ipython/ipykernel

status 'aborted' instead of 'abort'

未關閉
#367 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Python
星號
734
分支
412
平均合併
1 天 5 小時
30 天內合併 PR
8

描述

The [message spec](https://jupyter-client.readthedocs.io/en/latest/messaging.html#messages-on-the-shell-router-dealer-channel) has statuses `'ok'`, `'error'` and `'abort'`. However, messages which are aborted because they are in the queue when an execution results in an error with `stop_on_error` set get a reply with `status: 'aborted'`, instead of `'abort'`:

https://github.com/ipython/ipykernel/blob/35b1d1a823dd22a0fe4eb99e89463c2527a11271/ipykernel/kernelbase.py#L799-L810

We should probably just fix this, but since it affects any kernel based on Python, and apparently not many others use `status: 'abort'`, there's an argument for updating the message spec to match what the Python kernel has been doing.

There's also the issue that `'abort'` is deprecated in favour of using `'error'`, so maybe we should just change this code directly to use `'error'`.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。