ipython / ipython/ipykernel

status 'aborted' instead of 'abort'

Abierto
#367 2 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
734
Forks
412
Merge medio
1 d 5 h
PR fusionados (30 d)
8

Descripción

The [message spec](https://jupyter-client.readthedocs.io/en/latest/messaging.html#messages-on-the-shell-router-dealer-channel) has statuses `'ok'`, `'error'` and `'abort'`. However, messages which are aborted because they are in the queue when an execution results in an error with `stop_on_error` set get a reply with `status: 'aborted'`, instead of `'abort'`:

https://github.com/ipython/ipykernel/blob/35b1d1a823dd22a0fe4eb99e89463c2527a11271/ipykernel/kernelbase.py#L799-L810

We should probably just fix this, but since it affects any kernel based on Python, and apparently not many others use `status: 'abort'`, there's an argument for updating the message spec to match what the Python kernel has been doing.

There's also the issue that `'abort'` is deprecated in favour of using `'error'`, so maybe we should just change this code directly to use `'error'`.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Read the message specification and the referenced section of ipykernel/kernelbase.py around lines 799-810. Determine whether the intended fix is to retain the documented 'abort' status, update the spec for 'aborted', or use 'error'; done means the Python kernel behavior and applicable message specification agree.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python
Área
backend-api-design
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.