ipython / ipython/ipykernel

Removing `@register_integration("asyncio")` and `def loop_asyncio(kernel):`

オープン
#1,532 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Python
スター
734
フォーク
412
平均マージ
1日 5時間
マージ済み PR(30日)
8

説明

In current versions of ipykernel, when you execute in jupyter, vscode jupyter,
```
%gui asyncio
```
then after a while, when you execute
```
import asyncio
asyncio.all_tasks()```
```
you will get and see like
```
{.run_in_context() running at D:\test\ipykernel\ipykernel\utils.py:60> wait_for= cb=[Task.task_wakeup()]> cb=[ZMQStream._run_callback.._log_error() at e:\.pixi\envs\default\Lib\site-packages\zmq\eventloop\zmqstream.py:563]>,
cb=[Task.task_wakeup()]>}
```
It keeps increasing task count and it wastes your some cpu resource in the background. It's acually running these below codes, it just enters the function the return repeatedly, by `self.io_loop.call_later(0.001, advance_eventloop)` of `enter_eventloop()` in `kernelbase.py`.
https://github.com/ipython/ipykernel/blob/8816d024bf730e9fdb051b44ab2fc1ee2276cea2/ipykernel/eventloops.py#L430-L473

How it happened:
The `@register_integration("asyncio")` and `def loop_asyncio(kernel):` was at the old ages, to drive the asyncio codes that inputed by users, like `asyncio.ensure_future(...)`, when ipykernel was running under `IOloop` of `tornado<6.1` which using the `selectorloop` or even older type eventloop. It was to make users able to run asyncio codes when the underhood is other things.
The current ipykernel its main loop is already asyncio loop, by `IOloop` of `tornado>6.1`. The user inputed asyncio codes already run in the main loop.

Therefore the related codes `@register_integration("asyncio")` and `def loop_asyncio(kernel):` could be deleted.

Solution:
related issue: https://github.com/ipython/ipykernel/pull/1469 solving the proactor and selector eventloop within asyncio

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。