ipython / ipython/ipykernel

Should ipykernel align kernel SVG with the one used by JupyterLab?

Đang mở
#1,183 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
Ngôn ngữ chính
Python
Star
734
Fork
412
Merge trung bình
1 ngày 5 giờ
Pull request đã merge (30 ngày)
8

Mô tả

As per discussion in JupyterLab there seems to be a consensus to propose that ipykernel switches the svg icon to the one used in JupyterLab. Originally reported and discussed in https://github.com/jupyterlab/jupyterlab/issues/13991, included below for convenience:

>
>
> ## Description
>
> The buttons for launching a notebook with the Python kernel and for creating a new Python file both use a Python icon, but they look different. It is best to stick to one or the other to preserve consistency in the UI. This is of special significance given that this is what most users see first when launching JL.
>
> Screen Shot 2023-02-13 at 2 27 59 PM
>
>
> ## Reproduce
>
> 1. Open JupyterLab
> 2. Observe the Python icons are different
>
> ## Expected behavior
>
> The icons should be the same.
>
> ## Context
>
> - Operating System and version: OS X Monterey
> - Browser and version: Chrome 109.0.5414.119 (Official Build) (x86_64)
> - JupyterLab version: [4.0.0a33 binder](https://gist.github.com/jtpio/4e9a3d435d7c3950dc4150c10abbb1d7)
>
> I believe I had discussed this earlier when working on my [CSS PR](https://github.com/jupyterlab/jupyterlab/pull/12673) (now sadly abandoned). If I recall, the Python icons used at the top are actually coming from the kernel and are not hard-coded in the JL frontend. Would appreciate additional context from anybody knowledgable on this.
>
> _Originally posted by @dlqqq in https://github.com/jupyterlab/jupyterlab/issues/13991#issue-1583218948_

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.