ipython / ipython/ipykernel

Ipykernel replacement of `getpass` not fully compatible with it

未关闭
#1,123 3 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
734
派生
412
平均合并
1 天 5 小时
30 天内合并 PR
8

描述

The `getpass` API requires that the `GetPassWarning` is generated in case a password cannot be asked to the user in a secure way.

This is an important piece of the API, because it lets the programmer turn the warning into an error to handle the case when the terminal is not suited to securely prompt for a password *before* the user is asked for a password. In turn this is important because most users will carelessly type in a password regardless of any warning and is particularly bad for interfaces where the password will remain available for view via scrollback. Being able to handle the condition will let the program try different ways to get the password rather than prompting the user in an insecure way.

The problem here is that ipykernel replaces `getpass` with its own version that does not issue the `GetPassWarning`, so resulting in a different API from the standard `getpass` that ends up with the code prompting the user for a password insecurely without even realizing it.

At present time the workaround is clearly for the code to check if `getpass` comes from `ipykernel` and deal with this case specially.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。