ipython / ipython/ipykernel

Ipykernel replacement of `getpass` not fully compatible with it

Abierto
#1,123 3 comentarios 1 reacción 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
734
Forks
412
Merge medio
1 d 5 h
PR fusionados (30 d)
8

Descripción

The `getpass` API requires that the `GetPassWarning` is generated in case a password cannot be asked to the user in a secure way.

This is an important piece of the API, because it lets the programmer turn the warning into an error to handle the case when the terminal is not suited to securely prompt for a password *before* the user is asked for a password. In turn this is important because most users will carelessly type in a password regardless of any warning and is particularly bad for interfaces where the password will remain available for view via scrollback. Being able to handle the condition will let the program try different ways to get the password rather than prompting the user in an insecure way.

The problem here is that ipykernel replaces `getpass` with its own version that does not issue the `GetPassWarning`, so resulting in a different API from the standard `getpass` that ends up with the code prompting the user for a password insecurely without even realizing it.

At present time the workaround is clearly for the code to check if `getpass` comes from `ipykernel` and deal with this case specially.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.