ionic-team / ionic-team/vscode-ionic

Auto-import of ionic components fails when in-line comments are present

オープン
#175 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
bug
主要言語
TypeScript
スター
15
フォーク
3
PR マージ指標
30日以内にマージされた PR はありません

説明

I am 100% in love with the automatic importing of ionic components from the template - saves a lot of switching and helps keep me in the flow. However, I found today that the auto-importing suddenly stopped working on a single ionic template. I spent a bit of time tracking this issue down, and would like to know if there's a way around it?

After I added an in-line comment to the last member of my ionic angular import statement, the ionic extension would no longer automatically import any new Ionic components. For example:

```
import {
IonContent,
IonHeader,
IonTitle, //these are the defaults
}
```

With that comment at the end, auto-importing no longer works. If there's a comment after the first or second member, auto-importing works with no problem. And it looks like the presence of the trailing comma does not make a difference.

Putting the comment *below* the last entry in the import statement works, eg:
```
import {
IonContent,
IonHeader,
IonTitle,
//these are the defaults
}
```

Using the latest vscode (1.92.1), angular language service (18.2.0), and ionic extension (1.92.0). I obviously have a workaround - put the comment on the previous line or on a new line below the last member. But it'd be nice if I could put that comment back where I had it stylistically. I know this is pretty minor in the grand scheme of things, but hopefully it's an easy fix.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。