ionic-team / ionic-team/ionicons

incorrect icon: Improve close / checkmark icon.

Aperta
#1,195 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
help wanted type: incorrect icon
Lingua principale
TypeScript
Stelle
18.2k
Fork
2.1k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

### Describe the Issue

Just a minor but somewhat annoying issue from a meticulous UI dev. Especially when using `close` and `checkmark` icon together. It seems that either the `close` is not correct or `checkmark`. You can decide.

### Comparison

| Type | Close | Checkmark | Compare | Comment |
| --- | :-: | :-: | :-: | --- |
| outline |![1-close](https://user-images.githubusercontent.com/60390085/225056772-c2b65576-dcaf-4906-878c-469b01598bc0.png)|![1-checkmark](https://user-images.githubusercontent.com/60390085/225056845-2a021571-e687-4d6f-8299-d286ec2a25a9.png)|![compare-outline](https://user-images.githubusercontent.com/60390085/225056889-2857dbd1-3476-44fc-b94c-0d3035cb3b0e.gif)|Seems ok.|
| filled |![2-close](https://user-images.githubusercontent.com/60390085/225057206-5aad6506-1720-42f9-984f-7faea9c8a187.png)|![2-checkmark](https://user-images.githubusercontent.com/60390085/225057279-95d69329-2665-4c76-85d3-32dfb42c19f4.png)|![compare-filled](https://user-images.githubusercontent.com/60390085/225057392-4464cf82-8e40-47a9-979f-13b97c916374.gif)|The `close` appears too thick or the `checkmark` too thin.|
| sharp |![3-close](https://user-images.githubusercontent.com/60390085/225057772-686d071d-2796-4f16-82a4-af74e792fd6e.png)|![3-checkmark](https://user-images.githubusercontent.com/60390085/225057801-1c5d55b5-e13e-45cf-bf05-0fa74616fbef.png)|![compare-sharp](https://user-images.githubusercontent.com/60390085/225057836-50b6e863-c03f-4d62-a2a9-216b211e4973.gif)|Seems ok.|

![close](https://user-images.githubusercontent.com/60390085/225056108-7dea9701-83ec-4ff3-83ff-d17255dca068.gif)
![checkmark](https://user-images.githubusercontent.com/60390085/225056132-18883055-e7d8-4b23-9050-978eb3bc8269.gif)

We see that the `checkmark` outline and filled appear the same. The filled checkmark should be thicker or the cross thinner.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.