ionic-team / ionic-team/ionicons

incorrect icon: Improve close / checkmark icon.

Offen
#1,195 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
help wanted type: incorrect icon
Vorherrschende Sprache
TypeScript
Sterne
18.2k
Forks
2.1k
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

### Describe the Issue

Just a minor but somewhat annoying issue from a meticulous UI dev. Especially when using `close` and `checkmark` icon together. It seems that either the `close` is not correct or `checkmark`. You can decide.

### Comparison

| Type | Close | Checkmark | Compare | Comment |
| --- | :-: | :-: | :-: | --- |
| outline |![1-close](https://user-images.githubusercontent.com/60390085/225056772-c2b65576-dcaf-4906-878c-469b01598bc0.png)|![1-checkmark](https://user-images.githubusercontent.com/60390085/225056845-2a021571-e687-4d6f-8299-d286ec2a25a9.png)|![compare-outline](https://user-images.githubusercontent.com/60390085/225056889-2857dbd1-3476-44fc-b94c-0d3035cb3b0e.gif)|Seems ok.|
| filled |![2-close](https://user-images.githubusercontent.com/60390085/225057206-5aad6506-1720-42f9-984f-7faea9c8a187.png)|![2-checkmark](https://user-images.githubusercontent.com/60390085/225057279-95d69329-2665-4c76-85d3-32dfb42c19f4.png)|![compare-filled](https://user-images.githubusercontent.com/60390085/225057392-4464cf82-8e40-47a9-979f-13b97c916374.gif)|The `close` appears too thick or the `checkmark` too thin.|
| sharp |![3-close](https://user-images.githubusercontent.com/60390085/225057772-686d071d-2796-4f16-82a4-af74e792fd6e.png)|![3-checkmark](https://user-images.githubusercontent.com/60390085/225057801-1c5d55b5-e13e-45cf-bf05-0fa74616fbef.png)|![compare-sharp](https://user-images.githubusercontent.com/60390085/225057836-50b6e863-c03f-4d62-a2a9-216b211e4973.gif)|Seems ok.|

![close](https://user-images.githubusercontent.com/60390085/225056108-7dea9701-83ec-4ff3-83ff-d17255dca068.gif)
![checkmark](https://user-images.githubusercontent.com/60390085/225056132-18883055-e7d8-4b23-9050-978eb3bc8269.gif)

We see that the `checkmark` outline and filled appear the same. The filled checkmark should be thicker or the cross thinner.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Locate the filled close and checkmark icon assets and compare their stroke weights, starting with the comparison images in the issue. Adjust the filled variants so their visual weights are consistent, then verify the close/checkmark pairs in the outline, filled, and sharp styles.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Bereich
design
Issue-Typ
Bug
Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.