ionic-team / ionic-team/ionic-framework
bug: (ion-col) offset, push, and pull props are not RTL-aware
- Ngôn ngữ chính
- TypeScript
- Star
- 52.7k
- Fork
- 13.3k
- Merge trung bình
- 1 ngày 15 giờ
- Pull request đã merge (30 ngày)
- 51
Mô tả
### Prerequisites
- [X] I have read the [Contributing Guidelines](https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#creating-an-issue).
- [X] I agree to follow the [Code of Conduct](https://ionicframework.com/code-of-conduct).
- [X] I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already report this problem, without success.
### Ionic Framework Version
- [ ] v4.x
- [ ] v5.x
- [X] v6.x
- [ ] Nightly
### Current Behavior
The `offset`, `push`, and `pull` props for `ion-col` always offset/push/pull in the same direction (for example, always to the right for `offset`), regardless of whether the page is in LTR or RTL.
### Expected Behavior
The display of the columns should be a mirror image between LTR and RTL. For example, `offset` should push to the right in LTR and to the left in RTL.
### Steps to Reproduce
Offset: https://stackblitz.com/edit/rnuv7g?file=index.html
Push/pull: https://stackblitz.com/edit/jmyavm?file=index.html
Change the `dir` on the `body` tag from `ltr` to `rtl`. Notice that the layout does not get mirrored properly.
### Code Reproduction URL
https://stackblitz.com/edit/rnuv7g?file=index.html + https://stackblitz.com/edit/jmyavm?file=index.html
### Ionic Info
See Stackblitzes
### Additional Information
_No response_
Hướng dẫn đóng góp
Hướng nghiên cứu
Reproduce the issue using the two StackBlitz examples linked in the report, changing the body direction from ltr to rtl. Start at the ion-col component and trace how offset, push, and pull are applied; done means the column layout mirrors correctly in both directions.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- typescript
- Lĩnh vực
- frontend, internationalization
- Loại issue
- Lỗi
- Độ khó
- 3/5
- Thời gian dự kiến
- 1-2 ngày
- Mức độ hoạt động
- Đình trệ
- Độ rõ ràng
- Khá rõ ràng
- Mức phù hợp với người mới
- 45/100