ionic-team / ionic-team/ionic-framework
feat: ion-reorder-group optional require-long-press prop
- 主要言語
- TypeScript
- スター
- 52.7k
- フォーク
- 13.3k
- 平均マージ
- 1日 14時間
- マージ済み PR(30日)
- 50
説明
### Prequisites
- [X] I have read the [Contributing Guidelines](https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#creating-an-issue).
- [X] I agree to follow the [Code of Conduct](https://ionicframework.com/code-of-conduct).
- [X] I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already include this feature request, without success.
### Describe the Feature Request
Add a new require-long-press prop to ion-reorder-group which enables reorder only after an item has been long-pressed.
### Describe the Use Case
1. Using reorder on a list of ion-item elements wrapped in ion-reorder tags is currently unfeasible on touch devices. Moving your finger up or down an item immediately initiates reorder, which prevents the user from scrolling the page.
2. Currently ion-item-sliding doesn't work on ion-item elements wrapped in ion-reorder tags.
3. Long-pressing to reorder is a common UI feature. (See the iOS built-in Reminders app, among others.)
### Describe Preferred Solution
Add an optional require-long-press prop to ion-reorder-group, which if set to true would require a long press before starting reorder.
### Describe Alternatives
I tried using a custom long-press gesture to toggle the ion-reorder-group disabled prop from false to true, but this doesn't work because the initial press event then doesn't register in ion-reorder-group.
### Related Code
_No response_
### Additional Information
I'll be submitting a pull request which implements the feature in the next day or two.
コントリビューションガイド
調査の方向性
まず ion-reorder-group の実装と既存のジェスチャー処理を特定します。オプションの require-long-press 動作を追加し、長押し後にのみ並べ替えが開始されるようにしながら、通常のスクロールと既存の並べ替えのユースケースを維持します。コンポーネントの現在のテストを確認し、新しいインタラクションのカバレッジを追加します。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- typescript
- 領域
- frontend
- issue の種類
- 機能追加
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 45/100