ionic-team / ionic-team/ionic-cli

[Angular] ionic:serve hook does not work with cordova livereload

未關閉
#4,743 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
triage
主要語言
TypeScript
星號
2k
分支
681
PR 合併指標
30 天內沒有已合併 PR

描述

**Description:**
The current behavior of the `ionic:serve` hook is adding a new `--project` argument that breaks the call to the underlying angular command.

**Steps to Reproduce:**
In a brand new application, the following command works as expected:

```sh
ionic cordova run android --livereload
```

Running the previous command, we can see that it is actually calling `ng run app:ionic-cordova-serve --host=localhost --port=8100 --platform=android` under the hood. Keeping that in mind, I added the following hook:

```json
"ionic:serve": "ng run app:ionic-cordova-serve"
```

I thought this would be equivalent to the previous scenario. However, when I run the command again it is calling `ng run app:ionic-cordova-serve "--host=localhost" "--port=8100" "--platform=android" "--project=app"`, which generates the following error:

```
Unknown option: '--project'
```

**My `ionic info`:**

```
Ionic:

Ionic CLI : 6.16.3
Ionic Framework : @ionic/angular 5.6.7
@angular-devkit/build-angular : 0.1102.13
@angular-devkit/schematics : 11.2.13
@angular/cli : 11.2.13
@ionic/angular-toolkit : 3.1.1

Cordova:

Cordova CLI : 10.0.0
Cordova Platforms : android 9.1.0
Cordova Plugins : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.2.1, (and 4 other plugins)

Utility:

cordova-res : not installed globally
native-run : 1.4.0

System:

Android SDK Tools : 26.1.1
NodeJS : v14.17.0
npm : 6.14.13
OS : Linux 5.4
```

貢獻指南

開啟貢獻指南

研究方向

首先,使用 `ionic cordova run android --livereload` 和所示的 `ng run app:ionic-cordova-serve` 命令重現 ionic:serve hook 的行為。追蹤 ionic:serve hook 的引數處理,並驗證它不再加入 `--project=app`;當 Angular 命令能夠在沒有 Unknown option 錯誤的情況下執行時,即表示完成。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
angular, typescript
領域
cli
Issue 類型
缺陷
難度
3/5
預估耗時
1-2 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。