ionic-team / ionic-team/ionic-cli

Removing service worker for Cordova builds

Ouverte
#3,800 2 commentaires 6 réactions 0 personnes assignées Voir sur GitHub
triage
Langage dominant
TypeScript
Étoiles
2k
Forks
682
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

For a project that builds both Cordova native apps and PWAs via `ng add @angular/pwa` would be nice if the CLI removed the service worker when doing a Cordova build. Currently have to set the *serviceWorker* field in `angular.json` to false and remove the *ServiceWorkerModule* register in `app.module.ts` otherwise the Cordova build will try to register a service work and output an error (which it should). But would be nice if the CLI was able to handle this automatically based on if I'm doing a `ionic build --prod` for PWA or `ionic cordova run android` for native.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.