ionic-team / ionic-team/ionic-cli

Removing service worker for Cordova builds

Abierto
#3,800 2 comentarios 6 reacciones 0 asignados Ver en GitHub
triage
Lenguaje dominante
TypeScript
Estrellas
2k
Forks
682
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

For a project that builds both Cordova native apps and PWAs via `ng add @angular/pwa` would be nice if the CLI removed the service worker when doing a Cordova build. Currently have to set the *serviceWorker* field in `angular.json` to false and remove the *ServiceWorkerModule* register in `app.module.ts` otherwise the Cordova build will try to register a service work and output an error (which it should). But would be nice if the CLI was able to handle this automatically based on if I'm doing a `ionic build --prod` for PWA or `ionic cordova run android` for native.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.