hyperstack-org / hyperstack-org/hyperstack

add ability to mount a component from a router

オープン
#287 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
enhancement
主要言語
JavaScript
スター
538
フォーク
41
PR マージ指標
30日以内にマージされた PR はありません

説明

If a component is mounted from a router, then it won't work unless it is actually mounted from that router.

This makes hyper-specs `mount` method not work directly.

Instead you have to create a wrapper component that looks like this:

```ruby
class RouteToProfile < HyperComponent
include Hyperstack::Router
param :id
render do
Switch do
Route('/profile/:id', mounts: UserProfile)
Route('/') { Redirect("/profile/#{id}") }
end
end
end
```

then you can mount `RouteToProfile` and pass the id.

It should be possible to add a `route` option to the mount method, that if present will do the above by using a predefined RouteToComponent method, that takes as parameters the component to mount, the hash of route params, and the route.

For example

```ruby
mount 'Profile', {id: 1}, route: '/profile/:id'
```

would translate to
```ruby
mount 'RouteToComponent', route: '/profile/:id', params: {id: 1}
```
which would dynamically figure everything out.

In the meantime the work around is to follow the pattern above.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。