hyperstack-org / hyperstack-org/hyperstack

hyper-spec not working with webpack setup

未關閉
#145 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
bug
主要語言
JavaScript
星號
538
分支
41
PR 合併指標
30 天內沒有已合併 PR

描述

looks like if webpack is in use then the standard layout looks like:

```erb
<%= javascript_pack_tag 'hyperstack' %>
<%= javascript_include_tag 'application', 'data-turbolinks-track': 'reload' %>
```

but hyper-spec has not been trained to do this, and only includes the application tag by default.

Workaround for now is to add a `client_options layout: 'application'` in a before(:all) block in your spec helper. This will force hyper-spec to just use the application layout instead of building its own.

Solution is probably to add a webpack option that works like the hyper-spec javascript option, and then to default this value to `hyperstack`...

@barriehadfield can you weigh in... would we ever have a whole list of webpacks, or is it always going to be `hyperstack` for a standard setup?

貢獻指南

開啟貢獻指南

研究方向

Start by reading hyper-spec's client_options layout handling and the existing javascript option, then compare that path with the webpack setup shown in the issue. Determine how the standard webpack entry should be represented and verify that generated layouts include the needed hyperstack asset without the application-layout workaround.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
javascript, ruby, webpack
領域
build-system, testing-qa
Issue 類型
缺陷
難度
4/5
預估耗時
3-5 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。